Skip to content

Commit f38b5d5

Browse files
operator: add sha256 image upgrade test case in the unit test
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
1 parent 05ed072 commit f38b5d5

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

pkg/controllers/reconciler_test.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ package controllers
1616

1717
import (
1818
"context"
19+
"os"
20+
"path/filepath"
21+
"strings"
1922
"testing"
2023

2124
v1 "k8s.io/api/core/v1"
@@ -26,7 +29,10 @@ func TestUpgrade(test *testing.T) {
2629
initimage := "intel/intel-idxd-config-initcontainer"
2730
version := ":" + ImageMinVersion.String()
2831
prevVersion := ":" + ImageMinVersion.WithMinor(ImageMinVersion.Minor()-1).String()
32+
sha256 := "updatedrandomsha25642f7ad000a58eecc24ee7b75825227dfe28f23f556f62"
33+
preSha256 := "randomsha25642f7ad000a58eecc24ee7b75825227dfe28f23f556f62ec10f55"
2934
tests := []struct {
35+
envVars map[string]string
3036
image string
3137
initimage string
3238
expectedImage string
@@ -61,18 +67,33 @@ func TestUpgrade(test *testing.T) {
6167
expectedInitimage: initimage,
6268
upgrade: false,
6369
},
70+
{
71+
envVars: map[string]string{strings.ReplaceAll(strings.ToUpper(filepath.Base(image)), "-", "_") + "_SHA": image + "@sha256:" + sha256,
72+
strings.ReplaceAll(strings.ToUpper(filepath.Base(initimage)), "-", "_") + "_SHA": initimage + "@sha256:" + sha256},
73+
image: image + "@sha256:" + preSha256,
74+
expectedImage: image + "@sha256:" + sha256,
75+
initimage: initimage + "@sha256:" + preSha256,
76+
expectedInitimage: initimage + "@sha256:" + sha256,
77+
upgrade: true,
78+
},
6479
}
6580

6681
for i := range tests {
6782
t := tests[i]
6883

84+
for key, value := range t.envVars {
85+
os.Setenv(key, value)
86+
}
87+
6988
upgrade := UpgradeImages(context.Background(), &t.image, &t.initimage)
7089

7190
if !(upgrade == t.upgrade && t.image == t.expectedImage && t.initimage == t.expectedInitimage) {
7291
test.Errorf("expectedUpgrade: %v, received: %v", t.upgrade, upgrade)
7392
test.Errorf("expectedImage: %s, received: %s", t.expectedImage, t.image)
7493
test.Errorf("expectedInitimage: %s, received: %s", t.expectedInitimage, t.initimage)
7594
}
95+
96+
os.Clearenv()
7697
}
7798
}
7899

0 commit comments

Comments
 (0)