operator: fix upgradeImages

Operatorhub bundle can have sha256 image tags that are put through
env vars. When operator controller manager gets upgraded, its
operands (plugin daemonsets) should be updated to the image in the
env vars. But it has not been working properly because of wrong
parsing.

Fix it to parse the image names that have sha256 tags correctly so
env vars in operator can be used as intended.

Signed-off-by: Hyeongju Johannes Lee <[email protected]>

Author: hj-johannes-lee

pkg/controllers/reconciler.go

@@ -160,7 +160,7 @@ func UpgradeImages(ctx context.Context, image *string, initimage *string) (upgra
 		}
 
 		if parts := strings.SplitN(*s, ":", 2); len(parts) == 2 && len(parts[0]) > 0 {
-			name, version := parts[0], parts[1]
+			name, version := strings.TrimSuffix(parts[0], "@sha256"), parts[1]
 
 			envVarValue := os.Getenv(strings.ReplaceAll(strings.ToUpper(filepath.Base(name)), "-", "_") + "_SHA")