Generate --subpath for local targets #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages may need access to files outside of their subdirectory (e.g. hpack files may source other hpack files). Therefore it is important to keep the integrity of the project directory and specify individual subdirectories by passing `--subpath` to `cabal2nix`. Since `stack` does not support specifying subdirs for file paths (unlike git repositories), it is impossible to tell in general where is the root of the dependency. But we can at least do this for local targets.
Contributor
|
There is a test failing in travis ci. |
Author
|
Looking at the travis log it is hard to tell what exactly fails, but I suspect it is the last line of It is definitely wrong now, but I don’t know how to fix it, because I don’t know what it is supposed to test. Maybe @jmitchell can help me with this. It was introduced in a88e4ea, so probably taking a look at DEVOPS-282, which I don’t have access to, could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose there is a package with the following structure:
hpack/common.yamlsome useful hpack defiitionslib/package.yamlsources../hpack/common.yamlstack.yamlA call to
cabal2nix ./libwill generate a broken expression because it will havesrc = ./libwhich will cause nix to copy thelibdirectory into the store and then../hpack/common.yamlwill be unavailable.The correct invocation is
cabal2nix . --subpath lib.