Fix inim crash on Termux/Android #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inim was crashing immediately on startup with 'invalid indentation' error on line 10. Found that writeLine(EmbeddedCode) was adding an extra newline which broke the nim compiler parsing. Changed to write() with conditional newline check to fix it. Tested working on Termux with Nim 2.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inim was crashing immediately on startup with an 'invalid indentation' error on line 10. Found that writeLine(EmbeddedCode) was adding an extra newline, which broke the Nim compiler parsing.
Changed to write() with a conditional newline check to fix it.
Tested working on Termux(Android ARM64) with Nim 2.2.4
Inim now starts and runs correctly
Simple REPL operations work as expected.