Replace Surf with Reqwest to allow for upgrading Tokio to 1.x. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello @BoboFraggins, thanks for your PR 🚀 There's already an open PR for Reqwest at #92 by @msrd0. Did you have a chance to test if that also works for you? I intended on merging it soon once the CI errors are fixed. |
Collaborator
|
I think there's only the |
Collaborator
|
This PR does not seem to continue supporting async-std, which is probably undesirable |
Collaborator
|
I'm closing this in favour of #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is of interest to you, but I got into a dependency problem with Tokio. As I am more familiar with Reqwest and it is already on Tokio 1.x, I went the route of switching out Surf with Tokio. All of the tests pass locally and it appears to fully work for my use case. If you are interested in this PR, I'd be happy to clean up any changes you require, otherwise feel free to close it.
Thanks for the great library.