-
Notifications
You must be signed in to change notification settings - Fork 185
feat: bucket pagination #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bucket pagination #658
Conversation
8e90900 to
f3f0914
Compare
f3f0914 to
7bf9322
Compare
bednar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbenabda, thank you very much for your PR. Before we can proceed with merging, there are a few requirements that need to be met:
Co-authored-by: Jakub Bednář <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 90.40% 90.43% +0.02%
==========================================
Files 39 40 +1
Lines 3513 3524 +11
==========================================
+ Hits 3176 3187 +11
Misses 337 337 ☔ View full report in Codecov by Sentry. |
bednar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
LGTM 🚀
Proposed Changes
Simliar to #616 for buckets:
Add
buckets_api.find_buckets_iterto make usage of buckets pagination simplerChecklist
pytest testscompletes successfully