Skip to content

adds aria-labels that handle duplicate session titles in the same course. #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

adds aria-labels that handle duplicate session titles in the same course. #8893

wants to merge 1 commit into from

Conversation

@stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Oct 17, 2025 •
edited
Loading

@netlify
Copy link

netlify bot commented Oct 17, 2025 •
edited
Loading

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit e4ce47f
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/68f7e604b555d0000850d560
😎 Deploy Preview https://deploy-preview-8893--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stopfstedt stopfstedt force-pushed the 6567_session_title_deduping_for_a11y branch from 738c1e9 to 615e0f8 Compare October 17, 2025 23:31
@stopfstedt stopfstedt marked this pull request as ready for review October 17, 2025 23:33
@stopfstedt stopfstedt force-pushed the 6567_session_title_deduping_for_a11y branch from 615e0f8 to c0fd8a5 Compare October 17, 2025 23:45
@stopfstedt stopfstedt changed the title adds aria-labels than handle duplicate session titles in the same course. adds aria-labels that handle duplicate session titles in the same course. Oct 17, 2025
@stopfstedt stopfstedt force-pushed the 6567_session_title_deduping_for_a11y branch from c0fd8a5 to e4ce47f Compare October 21, 2025 19:58
michaelchadwick
michaelchadwick requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@michaelchadwick michaelchadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting sessions by status fails and results in an error

Image

@stopfstedt
Copy link
Member Author

Sorting sessions by status fails and results in an error
Image

Thanks for catching that, @michaelchadwick. Looks like we may have a gap in our test coverage on that as well then. I'll deal with them both.

@stopfstedt stopfstedt marked this pull request as draft October 24, 2025 04:55
@jrjohnson
Copy link
Member

I'd like to talk through this implementation a bit.

@stopfstedt stopfstedt marked this pull request as ready for review October 28, 2025 17:44
@stopfstedt stopfstedt marked this pull request as draft October 28, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelchadwick michaelchadwick michaelchadwick requested changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs Team Discussion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stopfstedt @jrjohnson @michaelchadwick