Add 'postgres-version' input parameter #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
force-pushed
the
postgres-version
branch
9 times, most recently
from
062ab3a to
d6592a6
Compare
ikalnytskyi
changed the title
ikalnytskyi
force-pushed
the
postgres-version
branch
14 times, most recently
from
d0ad37f to
c755f4a
Compare
ikalnytskyi
force-pushed
the
postgres-version
branch
6 times, most recently
from
1414e56 to
df742c9
Compare
ikalnytskyi
force-pushed
the
postgres-version
branch
13 times, most recently
from
31b45cc to
91d91a6
Compare
|
Hi, is this feature ready? |
ikalnytskyi
force-pushed
the
postgres-version
branch
10 times, most recently
from
654218e to
24b0119
Compare
One of the foundational principles of this action was to use GitHub runners preinstalled PostgreSQL binaries. The rationale was simple: * Make sure the action is fast and no installation is required. * Make sure it's safe and doesn't reach out to external servers. * Make sure the action is easy to audit. Unfortunately, those foundational principles aren't working well anymore due to the following reasons: * Ubuntu 24.04 is shipped with PostgreSQL 16, while other runners ship PostgreSQL 14. It's not nice when different versions are used on different runners. * macOS 13 & 14 runners are no longer shipped with preinstalled PostgreSQL, which means we have to install the server. * Many FOSS users are attracted by using the most recent PostgreSQL, and not stuck with few years old release. This patch adds a new `postgres-version` input parameter that controls what major version of PostgreSQL to install. Please note, the parameter receives only major part of the version, e.g. "14'. It's impossible to request any minor release. Co-Authored-By: Roman Podoliaka <[email protected]> Co-Authored-By: Ruslan Kiyanchuk <[email protected]> Resolves: #14
ikalnytskyi
force-pushed
the
postgres-version
branch
from
24b0119 to
b5b4c34
Compare
karlhorky
reviewed
Aug 20, 2024
Comment on lines
+65
to
+67
| postgres-version: | ||
| - "14" | ||
| - "15" |
Contributor
There was a problem hiding this comment.
should this include "16"? or no testing on the default version?
Owner
Author
There was a problem hiding this comment.
16 is tested as part of the default job. Just want to reduce the testing matrix a bit. :) It sometimes takes ages to find free windows/macos runners.
karlhorky
reviewed
Aug 20, 2024
| * PostgreSQL version can be parametrized. | ||
| * Easy [to verify][2] that it DOES NOT contain malicious code. | ||
|
|
||
| By default PostgreSQL 15 is used. |
Contributor
There was a problem hiding this comment.
I'm guessing this is a typo, and should instead be "16"
PR open:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the foundational principles of this action was to use GitHub
runners preinstalled PostgreSQL binaries. The rationale was simple:
Unfortunately, those foundational principles aren't working well
anymore due to the following reasons:
Ubuntu 24.04 is shipped with PostgreSQL 16, while other runners ship
PostgreSQL 14. It's not nice when different versions are used on
different runners.
macOS 13 & 14 runners are no longer shipped with preinstalled
PostgreSQL, which means we have to install the server.
Many FOSS users are attracted by using the most recent PostgreSQL,
and not stuck with few years old release.
This patch adds a new
postgres-versioninput parameter that controlswhat major version of PostgreSQL to install. Please note, the parameter
receives only major part of the version, e.g. "14'. It's impossible to
request any minor release.
Co-Authored-By: Roman Podoliaka [email protected]
Co-Authored-By: Ruslan Kiyanchuk [email protected]
Resolves: #14