Add port option. #1
Conversation
|
Hey @matt-42, Thanks for the contribution. Can you please provide some context on why it's needed? I mean, why would someone want to use a non-default PostgreSQL port on their CI? Is there some use case for that? |
action.yml
Outdated
| @@ -60,6 +65,8 @@ runs: | |||
| shell: bash | |||
|
|
|||
| - name: Setup PostgreSQL user and database | |||
| env: | |||
| PGPORT: ${{ inputs.port }} | |||
There was a problem hiding this comment.
This won't persist, and thus users' steps won't be able to use psql or createuser directly. We should persist it together with PGUSER and PGHOST in the step above. Can you please move it there?
There was a problem hiding this comment.
I'm writing a database driver and I wanted to test that it also work on a non default port. That's why I added this option.
There was a problem hiding this comment.
This won't persist, and thus users' steps won't be able to use
psqlorcreateuserdirectly. We should persist it together withPGUSERandPGHOSTin the step above. Can you please move it there?
Fixed in my last commit.
There was a problem hiding this comment.
I'm writing a database driver and I wanted to test that it also work on a non default port. That's why I added this option.
Makes sense. 👍
Fixed in my last commit.
Great! Thank you!
|
I just published |
No description provided.