-
Couldn't load subscription status.
- Fork 50
Add reduced basin functionality #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Wegatriespython
wants to merge
37
commits into
iiasa:main
Choose a base branch
from
Wegatriespython:reduced_basin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- M1 was erroneously more efficient than Mf
- Value of 0.8 inp means 1 unit water for 0.8 units of input
- Circular logic
- Minor change to values ommitted.
Unreasonable expectation for first model year here.
- desal act bound lo causes infeasibilties.
Harcoded heuristic for kinkyear.
- Input level at water_avail_basin - Input commodity surfacewater_basin - output level water_supply - output commodity freshwater
- Input level at water_avail_basin - Input commodity surfacewater_basin - output level water_supply - output commodity freshwater
consolidate return logic
Now water return flows follow a single path: cooling techs -> water_return commodity -> reg_to_basin tech -> surfacewater_basin
Bound = histroical cap at last historical year.
- Code was very messy
Use basin filtering everywhere More filtering More filtering Fix accidental removal Add basin reduction options Clean up filtering code Add min 1 basin region pair req Add reg_to_basin return tech consolidate return logic Fix failing tests Tests failure due to missing valid_basins list. Adding list to context to fix issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduced basin filtering options to enable running nexus locally for development.
The reduced basin tool is not intended to be used for production scenarios, as the basin reduction is not a realistic phenomena. Rather it is purely intended as a tool to enable local, fast runs of nexus module intended to speed up development processes.
This helps mitigate some of the issues mentioned in #414. The reduced basin model automatically picks 1 basin per region minimum. However for feasibility it is recommend to run with all basins for South Asia.
It is not intended to be merged in its current state as there are certain PRs that this branch depends upon which need to be merged first. This draft PR is intended to serve as documentation in the intermediate period.
How to use :
The branch has cli support
Or via script
How to review
PR checklist
- [ ] Continuous integration checks all ✅- [ ] Add or expand tests; coverage checks both ✅- [ ] Add, expand, or update documentation.- [ ] Update doc/whatsnew.