-
Notifications
You must be signed in to change notification settings - Fork 50
Documentation update for NEWPATHWAYS #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
- Coverage 77.1% 76.4% -0.8%
=======================================
Files 250 250
Lines 20198 20198
=======================================
- Hits 15589 15433 -156
- Misses 4609 4765 +156 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the documentation. I will add the trade portion.
|
Thanks for the PR and the review :) |
b014068 to
e8ed529
Compare
|
Thanks Fridolin! Rebased. (And I think we can tick the box unless Jun or anyone else sees any simple typos or obvious mistakes.) Paul helped update the whatsnew last time (New summary pages for projects :doc: And it is ok to merge with one reviewer confirmed. I actually filled documentation for quite a few projects (in branches doc/geidco, doc/newpathways, doc/elevate, doc/efc)... and will open PRs similar to this. It will be great if @khaeru can take a look too. |
|
Happy to hear that more docs updates are coming soon :) From my point of view, if you tell me that the information you added here is good, we can merge with a single approval. But if you think someone should take another look in particular, we can also wait until that person has time (and maybe tell them in person about this PR, including that it only takes x minutes to review). |
|
Please go ahead and merge. I think it will be much easier to tidy, edit, standardize in batches, once we can see what kinds of info are contained in the documentation for multiple projects. It's also simple to fill gaps if anyone later realizes some info was missing from this PR. No need to delay. |
|
Thanks both. I added the whatsnew of it and similar updates of EFC and ELEVATE documentations will come soon too. Kindly help with any tidy/edit/standardize/etc. then. |
|
(Merging this without waiting for the tests, which may not finish either way.) |
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
* Update minimum info for NEWPATHWAYS doc --------- Co-authored-by: Fridolin Glatter <[email protected]>
Update documentation for NEWPATHWAYS (a project starting from Jan 2025)
How to review
PR checklist
Add or expand tests;coverage checks both ✅p.s., once merged, Jun will be able to further work on the documentation of T3.5.
Aiming at updating the documentation when the next milestone is achieved (e.g., branches and workflows built for T3.3 or T3.5).