NAV: Mag declination fixes #4713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fiam
commented
May 16, 2019
fiam
commented
- Add script for automatically generating declination data
- Remove NAV_AUTO_MAG_DECLINATION, always compile with support for automatic declination
- Require a GPS fix before setting the automatic mag declination
In order to save flash on F3, there are 2 variants of the tables. F4 and up use floats up to +-90 latitude, while F3 uses int8_t up to +-60 latitude.
digitalentity
approved these changes
May 18, 2019
|
@fiam @giacomo892 tested today. Works and "going sideways" looks better than before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.