Updating parameters of SVC #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization which do not seem useful to optimize
* fmin return_argmin=False
This avoids crash if first trials are unsuccessful
* transform: X * 1 makes a copy to avoid a sklearn/numpy weirdness
around read-only views
|
It might also be worth throwing into this same request that with LinearSVC, loss labels like 'l1' and 'l2' have been deprecated in favor of 'hinge' and 'squared_hinge.' |
Member
Author
|
Good idea, I'll add that in as well. I also need to figure out how to clean up these commit messages, a bunch of older ones are showing up for this pull request and I'm not sure why. Can probably just squash them together. |
Member
Author
|
The parameter update has also been included in #41 so this PR is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest version of scikit-learn changed the API for the gamma parameter. Updating to match these changes.