Verify transactions in a block are well formed #4504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denyeart
reviewed
Oct 30, 2023
protoutil/blockutils_test.go
Outdated
| }, | ||
| { | ||
| name: "transaction invalid", | ||
| expectedError: "cannot parse invalid wire-format data", |
There was a problem hiding this comment.
In release-2.2, I had to change this to "illegal tag 0 (wire type 6)" to get unit test to pass due to the older dependencies.
There was a problem hiding this comment.
Yes I can see that much, from the output:
--- FAIL: TestVerifyTransactionsAreWellFormed (0.00s)
--- FAIL: TestVerifyTransactionsAreWellFormed/transaction_invalid (0.00s)
blockutils_test.go:502:
Error Trace: blockutils_test.go:502
Error: "transaction 0 is invalid: proto: common.Envelope: illegal tag 0 (wire type 6)" does not contain "cannot parse invalid wire-format data"
Test: TestVerifyTransactionsAreWellFormed/transaction_invalid
yacovm
force-pushed
the
wellForm-2.2
branch
2 times, most recently
from
d4c6ca2 to
34eed3a
Compare
Verify that transactions in blocks appear exactly as their marshaled form after unmarshaling. Signed-off-by: Yacov Manevich <[email protected]>
ale-linux
approved these changes
Oct 31, 2023
denyeart
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that transactions in blocks appear exactly as their marshaled form after unmarshaling.