Skip to content

Conversation

Krishnakumarskr
Copy link
Contributor

@Krishnakumarskr Krishnakumarskr commented Sep 3, 2025

Description

Updated the onwer and trusted ISM addresses

Backward compatibility

YES

Testing

NO

Summary by CodeRabbit

  • Chores
    • Updated interchain security module configurations and relayers for BSC, EDGEN, and Ethereum to current endpoints.
    • Rotated ownership for core contracts across networks; updated proxy admin ownership where applicable.
    • Maintained existing hooks/oracles/mailbox settings; no behavioral changes expected.
    • Improves cross-chain reliability and aligns governance with current operations.

Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: d623fb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

📝 Walkthrough

Walkthrough

Updates a single YAML: adjusts interchainSecurityModule addresses and relayers for bsc, edgenchain, and ethereum; changes owners across those networks; updates bsc proxyAdmin owner. No other fields altered.

Changes

Cohort / File(s) Summary
Warp route config updates
deployments/warp_routes/EDGEN/bsc-edgenchain-ethereum-deploy.yaml
- Updated interchainSecurityModule.address and .relayer for bsc, edgenchain, ethereum
- Updated owner for bsc, edgenchain, ethereum LayerEdge
- Updated bsc proxyAdmin.owner
- Other config fields unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • tkporter
  • yjamin
  • nambrot

Poem

New keys in the swamp, fresh guards at the gate,
Chains shake hands, and configs update.
Owners shift thrones, relayers take flight,
One tidy YAML, snug for the night.
Roll the routes onward—aye, that’s set right.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ed3a0cf and d623fb2.

📒 Files selected for processing (1)
  • deployments/warp_routes/EDGEN/bsc-edgenchain-ethereum-deploy.yaml (3 hunks)
🔇 Additional comments (9)
deployments/warp_routes/EDGEN/bsc-edgenchain-ethereum-deploy.yaml (9)

25-27: TrustedRelayerIsm: confirm relayer is live and authorized across agents

New relayer 0x3cd1…544a on bsc is fine on paper, but double-check:

  • The on-chain TrustedRelayerIsm has this relayer set.
  • Hyperlane relayer/validator infra is already pushing from this address.
  • No leftover allowlists block it.

If any of those lag, messages will stall. Holler if you want a quick checklist.


30-33: Owner and ProxyAdmin owner changed on bsc: ensure on-chain transfers already executed

Nice and tidy, but mind the sequence. If the ProxyAdmin ownership on-chain wasn’t transferred before merging this config, upgrades and pausing ops can get awkward. Same for the top-level owner expectations used by tooling. Please confirm the on-chain owners now equal:

  • bsc owner → 0xcf9a…8e1
  • bsc ProxyAdmin.owner → 0x70c3…993

If not, do the transfers first, then land this.


65-67: EDGEN chain: TrustedRelayerIsm updated—mirror the bsc checks

Same relayer 0x3cd1…544a here—good consistency. Please verify the on-chain ISM config and agent side are already switched over to avoid stuck routes.


70-73: EDGEN chain owner rotated but ProxyAdmin.owner not updated—intentional?

Top-level owner is now 0xcf9a…8e1, while proxyAdmin.owner remains 0xCC84…20c. If that’s by design, ignore me. If not, align it and perform the on-chain transfer before merging.


105-107: Ethereum: TrustedRelayerIsm switch—same due diligence

Relayer 0x3cd1…544a again; please confirm the ISM is set on-chain and the relayer infra is live from this key.


110-113: Ethereum owner rotated; ProxyAdmin.owner unchanged—confirm split-control

Owner → 0xcf9a…8e1 but proxyAdmin.owner stays 0xCC5d…899. If you intend separate upgrade authority, thumbs up. If not, update and transfer before rollout.


25-27: Quick kudos: consistent relayer across all three networks

Keeping a single relayer address across bsc/edgenchain/ethereum simplifies ops and monitoring. Looks clean.


25-33: Ignore hook suggestions—no hook. entries in this file*
I checked deployments/warp_routes/EDGEN/bsc-edgenchain-ethereum-deploy.yaml and there are no hook.owner, hook.beneficiary, or hook.oracleKey fields present, so nothing to rotate here.

Likely an incorrect or invalid review comment.


25-27: Manual sanity check needed for addresses & relayer consistency
Script couldn’t wrangle eth_utils; please give deployments/warp_routes/EDGEN/bsc-edgenchain-ethereum-deploy.yaml a once-over to ensure all updated EIP-55 checksummed (0x-prefixed, 42 chars) addresses are valid and that the relayer address matches across BSC, Edgenchain, and Ethereum.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant