[DoRA] Fix TypeError for LoRA config when use_dora is False in DreamBooth SDXL
#9842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Nov 2, 2024
Comment on lines
+1194
to
+1195
| if use_dora: | ||
| base_config["use_dora"] = True |
Member
There was a problem hiding this comment.
This would fail for lower version of peft where use_dora isn't present in the call args.
Author
There was a problem hiding this comment.
Thanks for pointing that out! Could you clarify which version of peft lacks use_dora in the call args?
Member
There was a problem hiding this comment.
diffusers/src/diffusers/loaders/peft.py
Line 220 in 13e8fde
Member
|
Gentle ping @adhiiisetiawan . |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeError that occurs in DreamBooth SDXL training with LoRA when
use_dora=False. Currently, the script always includes theuse_doraparameter in LoraConfig, causing errors with PEFT versions that don't support DoRA. This PR modifies the configuration to only include use_dora when it's explicitly enabled.Changes made:
get_lora_configto handle configuration creationFixes #9841
@sayakpaul