Skip to content

[Tests] fix slices of 26 tests (first half) #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 25, 2024
Merged

[Tests] fix slices of 26 tests (first half) #8959

merged 9 commits into from
Jul 25, 2024

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jul 25, 2024

What does this PR do?

As discussed internally.

Following test slices have been updated:

tests/pipelines/controlnet/test_controlnet_sdxl.py::StableDiffusionXLControlNetPipelineFastTests::test_controlnet_sdxl_guess
tests/pipelines/kandinsky2_2/test_kandinsky_combined.py::KandinskyV22PipelineCombinedFastTests::test_kandinsky
tests/pipelines/kandinsky/test_kandinsky_combined.py::KandinskyPipelineCombinedFastTests::test_kandinsky
tests/pipelines/controlnet/test_controlnet_sdxl.py::StableDiffusionXLControlNetPipelineFastTests::test_ip_adapter_single
tests/pipelines/kandinsky2_2/test_kandinsky_combined.py::KandinskyV22PipelineImg2ImgCombinedFastTests::test_kandinsky
tests/pipelines/kandinsky/test_kandinsky_combined.py::KandinskyPipelineImg2ImgCombinedFastTests::test_kandinsky
tests/pipelines/kandinsky/test_kandinsky_combined.py::KandinskyPipelineInpaintCombinedFastTests::test_kandinsky
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_img2img.py::StableDiffusionXLImg2ImgPipelineFastTests::test_ip_adapter_single
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_adapter.py::StableDiffusionXLAdapterPipelineFastTests::test_ip_adapter_single
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_adapter.py::StableDiffusionXLAdapterPipelineFastTests::test_stable_diffusion_adapter_default_case
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl.py::StableDiffusionXLPipelineFastTests::test_ip_adapter_single
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_adapter.py::StableDiffusionXLMultiAdapterPipelineFastTests::test_ip_adapter_single
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_adapter.py::StableDiffusionXLMultiAdapterPipelineFastTests::test_stable_diffusion_adapter_default_case
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl.py::StableDiffusionXLPipelineFastTests::test_stable_diffusion_xl_euler
tests/pipelines/controlnet/test_controlnet_sdxl.py::StableDiffusionSSD1BControlNetPipelineFastTests::test_controlnet_sdxl_guess
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py::StableDiffusionXLInpaintPipelineFastTests::test_ip_adapter_single
tests/pipelines/controlnet/test_controlnet_sdxl.py::StableDiffusionSSD1BControlNetPipelineFastTests::test_ip_adapter_single
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py::StableDiffusionXLInpaintPipelineFastTests::test_stable_diffusion_xl_inpaint_euler
tests/pipelines/pag/test_pag_sdxl.py::StableDiffusionXLPAGPipelineFastTests::test_pag_inference
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py::StableDiffusionXLInpaintPipelineFastTests::test_stable_diffusion_xl_refiner
tests/pipelines/pag/test_pag_sdxl_img2img.py::StableDiffusionXLPAGImg2ImgPipelineFastTests::test_pag_inference
tests/pipelines/controlnet/test_controlnet_sdxl_img2img.py::ControlNetPipelineSDXLImg2ImgFastTests::test_ip_adapter_single
tests/pipelines/pag/test_pag_sdxl_inpaint.py::StableDiffusionXLPAGInpaintPipelineFastTests::test_pag_inference
tests/pipelines/pag/test_pag_controlnet_sdxl.py::StableDiffusionXLControlNetPAGPipelineFastTests::test_pag_cfg
tests/pipelines/pag/test_pag_controlnet_sdxl.py::StableDiffusionXLControlNetPAGPipelineFastTests::test_pag_uncond

@sayakpaul sayakpaul requested a review from DN6 July 25, 2024 02:08
DN6
DN6 reviewed Jul 25, 2024
View reviewed changes
utils/overwrite_expected_slice.py
done_tests = defaultdict(int)
for line in correct_lines:
file, class_name, test_name, correct_line = line.split(";")
file, class_name, test_name, correct_line = line.split("::")
Copy link
Collaborator

@DN6 DN6 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a bug in this script when identifying the test modules where slices need to be replaced.

@sayakpaul sayakpaul merged commit d8bcb33 into main Jul 25, 2024
@sayakpaul sayakpaul deleted the fix-half-slices branch July 25, 2024 09:26
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@sayakpaul @DN6
[Tests] fix slices of 26 tests (first half) (#8959)
015019a 
* check for assertions.

* update with correct slices.

* okay

* style

* get it ready

* update

* update

* update

---------

Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 DN6 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakpaul @DN6