-
Couldn't load subscription status.
- Fork 6.5k
support latest few-step wan LoRA. #12541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The new high noise Lightning lora is loading perfectly now thanks! I noticed that the new low noise Lightning lora is still having issues with unexpected keys. It loads with these warnings, but the quality of the videos makes it seem like it is not loading correctly. The old low noise Lightning lora works with it though. |
|
I also just noticed that the old Wan 2.1 light lora is failing to load in Wan2 2.2 with this commit, getting the following error: Code to reproduce: |
I pushed some changes which should help with the loading problem but even in Will check further. |
Yes, that was always an issue with some wan 2.1 Loras loading in wan 2.2. It still loads and functions correctly though. I have just tested them all and everything seems to be working correctly now for the new high/low noise lightning models and the old wan 2.1 Loras loading in wan 2.2(even with the key errors). Thanks a lot 🙏 |
|
Thanks for confirming. So, are we good to merge? 👀 |
|
@sayakpaul I did a run with this too and at first glance it seems to work (I don't see a difference in quality) but the console output is really big with the unexpected keys. I'll do a test using only the low noise model and see if there is a difference in quality. |
|
this is a hard one for me, I did the experiment with just the low noise, just the high noise and both of them, the quality doesn't suffer but the motion in the low one changed quite a bit, this produces a slow motion with both too. I remember I read somewhere that this lora fixed the slow motion but also read some people saying that it didn't. I'll test this with ComfyUI sometime soon but I have to download everything again to use it with it and see if it works different there. in the meantime I think we're good to merge @sayakpaul and if I find something later, maybe we can follow with another PR? |
|
Failing tests are unrelated. |
What does this PR do?
Fixes #12535
@ljk1291, could you check this?