store activation cls instead of function #10832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Feb 19, 2025
Contributor
a-r-r-o-w
left a comment
a-r-r-o-w
left a comment
There was a problem hiding this comment.
Thanks for looking into it @SunMarc!
Context for other reviewers: https://huggingface.slack.com/archives/C065E480NN9/p1739907879056729
| if is_torch_npu_available(): | ||
| import torch_npu | ||
|
|
||
| ACTIVATION_FUNCTIONS = { |
Contributor
There was a problem hiding this comment.
Looks like a safe change. I could not find anything via github search that might be impacted but I did not search too many cases
Member
Author
There was a problem hiding this comment.
Yeah I tried to look also, should be a safe change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10822. The activations function were stored in a dict, so if we load a models with hooks that contains activation function then we load a new model without hooks, the new model still ends up with hooks on the activation layers. This is because the same activation were used. To fix the issue, we just need to make sure to instantiate from the class.