SGMUniform scheduler for Hyper loras needs support!

[rollingcookies]

Is your feature request related to a problem? Please describe.
Your library is used in a great product like Invoke! And SGMUniform scheduler is needed to support Hyper loras! Please add support for this scheduler in diffusers library!

Describe the solution you'd like.
Add scheduler - SGMUniform

Describe alternatives you've considered.
So far, I haven't found an alternative solution.

[asomoza]

Hi, thanks for opening the issue. Can you please post some images were we can see the quality of the scheduler? I like a lot to use TCD since I think is the best for this use case so maybe you can compare them?

As an alternative, we have TCD, Euler and LCM that work with HyperSD though.

[rollingcookies]

Hi! Unfortunately my version of Forge does not have a TCD scheduler, I can only compare it to Euler.

Euler

Euler SGMUniform

Euler

Euler SGMUniform

Euler

Euler SGMUniform

Euler

Euler SGMUniform

Euler

Euler SGMUniform

Euler

Euler SGMUniform

[asomoza]

Thank you for the examples, sadly we can't compare it to the best one we have for this right now, but It does make the image cleaner, I can see the difference. I read some people saying that it's the recommended scheduler for lighting and hyper but in the official repo they recommend this:

Lighting

# Ensure sampler uses "trailing" timesteps and "sample" prediction type.
pipe.scheduler = EulerDiscreteScheduler.from_config(pipe.scheduler.config, timestep_spacing="trailing", prediction_type="sample")

Hyper-SD

# Use TCD scheduler to achieve better image quality
pipe.scheduler = TCDScheduler.from_config(pipe.scheduler.config)

I don't know the implementation of SGMUniform but if we don't have it, it could make sense to add it, I can't add it or make the decision about it though, @yiyixuxu WDYT?

[yiyixuxu]

ok we can open an issue to see if anyone in the community wants to contribute first? @asomoza

[rollingcookies]

@asomoza @yiyixuxu Thank you for your efforts, hopefully it will come to realization. I tried to implement also comparison on the same Prompts and Seeds in Comfi, unfortunately for TSD Scheduler there is no possibility to use A1111 emulation, because it is implemented via SamplerCustom node. But for Euler SGMUniform it was possible to use KSampler (inspire) node which has A1111 support. So that also influenced the result.

My verdict: the best and cleanest result is Euler SGMUniform in Forge, second place is Euler SGMUniform from Comfi with A1111 emulation, and the last place is TCD (Comfi, node TCD ModelSampling Discrete).

Euler SGMUniform

TCD

Euler SGMUniform

TCD

Euler SGMUniform

TCD

Euler SGMUniform

TCD

Euler SGMUniform

TCD

Euler SGMUniform

TCD

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[asomoza]

closing this since we have a diffusers equivalent of this and was added to the docs with this PR.