Skip to content

Conversation

@dnkoutso
Copy link
Contributor

The .swift-version file has been deprecated and by specifying that in the podspec it means that consumers of Swifter will always get the correct version of Swift when compiling Swifter.

@dnkoutso dnkoutso force-pushed the swift_version_podspec branch from 50b2223 to 6487429 Compare July 20, 2019 21:54
@swifter-bot
Copy link

swifter-bot commented Jul 20, 2019

2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @dnkoutso 👋.

Generated by 🚫 Danger

@dnkoutso
Copy link
Contributor Author

let me know if you do not want to point to stable branch.

@dnkoutso dnkoutso force-pushed the swift_version_podspec branch from 6487429 to 8eea555 Compare July 20, 2019 21:57
Copy link
Member

@Vkt0r Vkt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnkoutso Thanks for taking the time to create this PR! Looks good 👍.

@Vkt0r Vkt0r merged commit 70355c4 into httpswift:stable Jul 21, 2019
@dnkoutso
Copy link
Contributor Author

thank you!

tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
Use `swift_versions` DSL instead of `.swift-version` file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants