fix parsing url strings with brackets #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when path contains 'weird' characters (`[]`) URLComponents won't parse it, so the path will be nil * escaping the string with `urlQueryAllowed` character set fixes this issue
Generated by 🚫 Danger |
|
@nejcvivod Thanks for creating this PR! That's a good catch, can you please provide an entry in the |
* added `update` entries to CHANGELOG.md describing fixed parsing & new test * fix invalid test, don't need the full domain in parser * ran `swift test --generate-linuxmain`
|
@Vkt0r updated changelog & ran the command @swifter-bot posted :) |
Vkt0r
reviewed
Jul 15, 2019
Vkt0r
reviewed
Jul 15, 2019
|
@Vkt0r updated |
Vkt0r
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
This looks good to me @nejcvivod. Thanks again for your contribution!
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
fix parsing url strings with brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue (on ios at least) where URLs with
[]query parameters are not parsed; URLComponents will producenilso routing won't succeed.This fix escapes the strings by percent-encoding them so query parameters should now work as expected.
Added unit test for such a case