Skip to content

Parse HttpRequest Path without Query String #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2019
Merged

Parse HttpRequest Path without Query String #404

merged 2 commits into from
May 2, 2019

Conversation

@Mazyod
Copy link
Contributor

@Mazyod Mazyod commented May 1, 2019

This PR parses the URL using URLComponents, then assigns the path property of HttpRequest to the components.path. This parity with Foundation API is desirable I believe, and adheres to the Principle of Least Astonishment 😄.

With this fix, two other notable changes are also made:

  1. Minimum deployment target for macOS is bumped to 10.10
  2. Query parsing code is removed in favor of Foundation API parsing using URLComponents

Fixes #391

@swifter-bot
Copy link

swifter-bot commented May 1, 2019 •
edited
Loading

2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @Mazyod 👋.

Generated by 🚫 Danger

@Mazyod
Copy link
Contributor Author

Mazyod commented May 1, 2019

Passed linux in one go this time 😌

@Mazyod
Fix path to resolve only path part
64266cf 
# Conflicts:
#	XCode/Sources/HttpParser.swift
#	XCode/Swifter.xcodeproj/project.pbxproj
#	XCode/Tests/SwifterTestsHttpParser.swift
@Mazyod Mazyod force-pushed the bugfix/parse-path-without-query branch from b9114a9 to 364f3a8 Compare May 1, 2019 05:22
@Mazyod Mazyod force-pushed the bugfix/parse-path-without-query branch from 364f3a8 to fb4ba22 Compare May 1, 2019 05:23
Vkt0r
Vkt0r approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@Vkt0r Vkt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks 👍

@Vkt0r Vkt0r merged commit 3367b63 into httpswift:stable May 2, 2019
@Mazyod Mazyod deleted the bugfix/parse-path-without-query branch May 3, 2019 12:29
@Vkt0r Vkt0r mentioned this pull request May 6, 2019
Merged
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#404 from Mazyod/bugfix/parse-path-withou…
e766955 
…t-query

Parse HttpRequest Path without Query String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vkt0r Vkt0r Vkt0r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HttpRequest Path Includes Query String

3 participants

@Mazyod @swifter-bot @Vkt0r