Pause mode fixes #1735
Draft
Pause mode fixes #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b739b6. Not sure about the context of the reverted patch, but it prevents sorting when paused.
|
Thank you for trying to improve htop! 7b739b6 was intentional as the data is not updated so the sort may be showing wrong data / wrong child nodes. Personally I also think the "PAUSED" indicator is sufficiently visible and fits better into the design than your proposal. But I am happy to have others chime in on this. (Design) taste is always subjective. |
|
Can the OP (@eMPee584) clarify what problem this PR is trying to fix? Without a report of an issue, I can't understand why this PR is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.