Skip to content
This repository was archived by the owner on Dec 24, 2019. It is now read-only.

Conversation

hjacobs
Copy link
Owner

@hjacobs hjacobs commented Feb 11, 2017

Do not scale down if..

  • ..any ASG activity is still in progress
  • ..the number of ready nodes is lower than the ASG's current DesiredCapacity (this means that a node is probably booting and not registered in the API server yet)

Also do not compensate cordoned nodes which are currently being terminated by ASG (important to support kube-node-drainer.service as introduced in zalando-incubator/kubernetes-on-aws#257).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0f48747 on no-scale-down-on-scaling-activity into 3dc6f6e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d09a2b3 on no-scale-down-on-scaling-activity into 3dc6f6e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f965680 on no-scale-down-on-scaling-activity into 3dc6f6e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f5fc782 on no-scale-down-on-scaling-activity into 3dc6f6e on master.

@hjacobs hjacobs merged commit f95b091 into master Feb 11, 2017
@hjacobs hjacobs deleted the no-scale-down-on-scaling-activity branch February 11, 2017 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants