This repository was archived by the owner on Dec 24, 2019. It is now read-only.
Initial ASG Health Endpoint #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjacobs
reviewed
Sep 12, 2017
tests/test_autoscaler.py
Outdated
| assert list(chunks([1, 2, 3], 2)) == [[1, 2], [3]] | ||
|
|
||
|
|
||
| class FlaskTest(unittest.TestCase): |
There was a problem hiding this comment.
you don't need unittest.TestCase, just use the usual py.test style as all other tests do (simple functions)
|
@hjacobs can you provide us feedback or get this merged? Once we have this feature we can implement better monitoring on ASGs that fail to scale. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to update the cluster-autoscaler to add an healthcheck. We want to use this to identify when scaling attempts fail and take action on that. This is a very simple approach that could probably be improved to export proper metrics that are more actionable than just an health endpoint.