Skip to content

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Oct 13, 2025

Based on this PR: #2520
Here's a list of the disabled tests:

return new SessionImpl( delegate, this );
}
};
return (SessionCreationOptions) sessionBuilder.tenantIdentifier( tenantIdentifier );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
SessionBuilderImpl.tenantIdentifier
should be avoided because it has been deprecated.
}

return javaTypeRegistry.resolveDescriptor( Object[].class );
return javaTypeRegistry.getDescriptor( Object[].class );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
JavaTypeRegistry.getDescriptor
should be avoided because it has been deprecated.
@DavideD DavideD force-pushed the ORM-7.2.0.CR1 branch 2 times, most recently from 404c2dd to af511bb Compare October 20, 2025 13:30
@DavideD DavideD linked an issue Oct 20, 2025 that may be closed by this pull request
@DavideD DavideD force-pushed the ORM-7.2.0.CR1 branch 3 times, most recently from 8bb611f to 5a443c4 Compare October 20, 2025 15:12
@DavideD DavideD force-pushed the ORM-7.2.0.CR1 branch 2 times, most recently from f20e083 to 77cdf7a Compare October 22, 2025 10:27
LazyInitializationException.class, getMutinySessionFactory()
.withTransaction( session -> session.persist( emily ) )
.chain( () -> getMutinySessionFactory().withSession( session -> {
Crew crew = session.getReference( Crew.class, emily.getId() );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'String role' is never read.
dreab8 and others added 9 commits October 22, 2025 12:55
Fixes

* return the right lock (different than ORM)
* Fix postLoad issue
HIbernate ORM 7.2 now calls this method when it needs to enable
bytecode enhancements
I don't know if this test actually makes sense:
the cancel opertion happens in a different thread that causes
some error when calling session.close because the thread doesn't match
the one the session was open.

I'm going to keep it because it was introduced to solve hibernate#1436
but we might need to review it again in the future.
@DavideD DavideD marked this pull request as ready for review October 22, 2025 11:01
@DavideD DavideD requested a review from dreab8 October 22, 2025 11:01
@DavideD
Copy link
Member Author

DavideD commented Oct 22, 2025

@dreab8 Thanks a lot, I think we can merge this.

I will create separate issues for the tests that are disabled and we can continue from there.
Unless you find something to change when you review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Hibernate ORM to 7.2

2 participants