Wire in SqlExceptionHelper which is now useful in Vert.x 4.4.0 #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we need all those try-catch. I think we can rely on the fact that the method will return a failed stage.
gavinking
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some conflicts with the changes I made for the autodetection of the version of the dialect.
I had to add a couple of methods to
ReactiveConnectionPoolbecause the defaultSqlExceptionHelperneeds a dialect and we don't have the dialect during yet when we create the connection to check the version on the database.Because it uses the latest ORM, we don't need to skip the test for SqlServer anymore.
Fix #1602