Skip to content

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Apr 19, 2023

There were some conflicts with the changes I made for the autodetection of the version of the dialect.
I had to add a couple of methods to ReactiveConnectionPool because the default SqlExceptionHelper needs a dialect and we don't have the dialect during yet when we create the connection to check the version on the database.

Because it uses the latest ORM, we don't need to skip the test for SqlServer anymore.

Fix #1602

DavideD added 2 commits April 19, 2023 18:13
I don't think we need all those try-catch.
I think we can rely on the fact that the method will
return a failed stage.
@DavideD DavideD merged commit b754227 into hibernate:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wire in SqlExceptionHelper which is now useful in Vert.x 4.4

2 participants