DOC-573: add mount PVC topic #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pedantic-goldberg-f76ec1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SeriyBg
approved these changes
Sep 3, 2025
oliverhowell
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Minor comments/suggestions - wonder if it's worth linking https://docs.hazelcast.com/hazelcast/5.5/getting-started/persistence (now that I've fixed it in the Enterprise PR)?
| @@ -0,0 +1,41 @@ | |||
| = Mount Persistent Volume Claims for Hazelcast clusters | |||
There was a problem hiding this comment.
Suggested change
| = Mount Persistent Volume Claims for Hazelcast clusters | |
| = Mount Persistent Volume Claims (PVCs) for Hazelcast clusters |
WDYT?
There was a problem hiding this comment.
Since the first line explains this "You can mount one or more Persistent Volume Claims (PVCs) directly to your Hazelcast cluster" and in the interest of keeping the headings short, I think it's best to leave as is
|
|
||
| == How it works | ||
|
|
||
| - Define one or more PVCs in the persistenceVolumeClaims section of your Hazelcast custom resource (CR). |
There was a problem hiding this comment.
Suggested change
| - Define one or more PVCs in the persistenceVolumeClaims section of your Hazelcast custom resource (CR). | |
| - Define one or more PVCs in the `persistenceVolumeClaims` section of your Hazelcast custom resource (CR). |
|
|
||
| == Example: Configure diagnostics with a named PVC | ||
|
|
||
| Below is an example configuration that shows how to define a PVC and use it for diagnostics logging by specifying the pvcName field. The diagnostics logs will be stored in the PVC mounted at `/data/diagnostics-pvc-volume`. |
There was a problem hiding this comment.
Suggested change
| Below is an example configuration that shows how to define a PVC and use it for diagnostics logging by specifying the pvcName field. The diagnostics logs will be stored in the PVC mounted at `/data/diagnostics-pvc-volume`. | |
| Below is an example configuration that shows how to define a PVC and use it for diagnostics logging by specifying the `pvcName` field. The diagnostic logs will be stored in the PVC mounted at `/data/diagnostics-pvc-volume`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://hazelcast.atlassian.net/browse/DOC-573
As part of the Diagnostic Logging work, we need to document how to mount one or more Persistent Volume Claims (PVCs) directly to a Hazelcast cluster.
Sergii suggests this goes into a new topic under Configuration properties.
The work to add the fields to the CRD has been done in PR: https://github.com/hazelcast/hazelcast-platform-operator/pull/1432