making hls-cabal and hls-hlint faster #4332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
you might also need to consider the debouncer delay But in fact if you want to reliably replace it. You might need to consider a lot of internal working in hls. See #4300 |
Contributor
Author
|
looking into it, thanks! |
komikat
changed the title
fendor
requested changes
Jul 10, 2024
| _ <- waitForTypecheck hsDoc | ||
| cabalDoc <- openDoc "simple-cabal.cabal" "cabal" | ||
| expectNoMoreDiagnostics 1 cabalDoc "parsing" | ||
| _ <- waitForAction "gethieast" cabalDoc |
Collaborator
There was a problem hiding this comment.
I cannot imagine this works, cabal files don't run this action, right?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectNoMoreDiagnostics 1waits for 1 second to establish that no diagnostics have been created, it has been replaced withwaitForTypecheckandwaitForAction "gethieast"for Haskell and cabal files respectively, shaving off 1 second each time. I'm not sure if I should wait for some other action for cabal files.