Fix various issues #4024
Merged
Fix various issues #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc also @jhrcek |
jhrcek
approved these changes
Jan 29, 2024
Collaborator
jhrcek
left a comment
jhrcek
left a comment
There was a problem hiding this comment.
Two nitpicks, otherwise nice consolidation. I'll update my open PRs once this is merged.
| test-suite func-test | ||
| import: common-deps | ||
| import: defaults | ||
| , test-defaults |
Collaborator
There was a problem hiding this comment.
You can remove "-threaded -rtsopts -with-rtsopts=-N" from func-test now that you're importing test-defaults
| if impl(ghc >= 9.5) | ||
| buildable: False | ||
| type: exitcode-stdio-1.0 | ||
| default-language: Haskell2010 |
Collaborator
There was a problem hiding this comment.
You can remove -Wall -Wno-name-shadowing from benchmark now that you're importing warnings.
fendor
approved these changes
Jan 29, 2024
Collaborator
Author
|
Some |
michaelpj
force-pushed
the
mpj/central-cabal-tidying
branch
from
5b9b487 to
dd74b75
Compare
Collaborator
|
The ghcide tests looks like they suddenly are picking up HLS as the cradle root which is taking forever and probably wrong. I can look into it. |
- Make sure that we are always referring to the local libraries and not
the published Hackage packages!
- This needs a `cabal-version` bump
- Make sure every component imports the default stanzas
- Add a `defaults` stanza for `default-language`
- Add a `tests-default` stanza for making sure test suites are built
threaded
- Remove unnecessary warning-related `ghc-options`
- Use the `pedantic` stanza instead of manual checks for `pedantic`
michaelpj
force-pushed
the
mpj/central-cabal-tidying
branch
from
dd74b75 to
b4d9eb5
Compare
Collaborator
Author
|
hooray, green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first thing here is quite bad - my mistake! Unfortunately I got it all tangled in some other changes, but I think they're uncontroversial.
cabal-versionbumpdefaultsstanza fordefault-languagetests-defaultstanza for making sure test suites are built threadedghc-optionspedanticstanza instead of manual checks forpedantic