Skip to content

Fix -Wall and -Wunused-packages in explicit fixity plugin #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix -Wall and -Wunused-packages in explicit fixity plugin #3995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions plugins/hls-explicit-fixity-plugin/hls-explicit-fixity-plugin.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ source-repository head
type: git
location: https://github.com/haskell/haskell-language-server.git

common warnings
ghc-options:
-Wall -Wunused-packages
-Wno-name-shadowing -Wno-unticked-promoted-constructors

library
import: warnings
exposed-modules: Ide.Plugin.ExplicitFixity

hs-source-dirs: src
Expand All @@ -28,22 +34,17 @@ library
, containers
, deepseq
, extra
, ghc
, ghcide == 2.6.0.0
, hashable
, hls-plugin-api == 2.6.0.0
, lsp >=2.3
, text
, transformers

ghc-options:
-Wall
-Wno-name-shadowing
-Wno-unticked-promoted-constructors
default-language: Haskell2010
default-extensions: DataKinds

test-suite tests
import: warnings
type: exitcode-stdio-1.0
default-language: Haskell2010
hs-source-dirs: test
Expand Down
3 changes: 1 addition & 2 deletions plugins/hls-explicit-fixity-plugin/test/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,10 @@ hoverTest' docName title pos expected = testCase title $ runSessionWithServer de
doc <- openDoc docName "haskell"
waitForKickDone
h <- getHover doc pos
let expected' = "\n" <> sectionSeparator <> expected
case h of
Nothing -> liftIO $ assertFailure "No hover"
Just (Hover contents _) -> case contents of
InL (MarkupContent mk txt) -> do
InL (MarkupContent _ txt) -> do
liftIO
$ assertBool ("Failed to find `" <> T.unpack expected <> "` in hover message: " <> T.unpack txt)
$ expected `T.isInfixOf` txt
Expand Down