Actually force usages #3713
Merged
Actually force usages #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems to not build on all GHCs |
wz1000
force-pushed
the
wip/usage-leak
branch
3 times, most recently
from
2c81b4f to
9ade701
Compare
michaelpj
approved these changes
Jul 25, 2023
Collaborator
|
Still doesn't build. |
Unfortunately the `mi_usages` is evaluated by `checkOldIface` before we have a chance to do the sharing, resulting in them not actually being shared on the first load. Solution is to share the usages before `checkOldIface` has a chance to inspect them, breaking the sharing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 00f4e61 we attempted to share the filepaths in GHC's usage field.
Unfortunately the
mi_usagesfield is lazy and so these turned out to not actually be shared becausethe thunk responsible for sharing was never evaluated.
Add the right strictness annotations to ensure these are actually shared