Split pragmas plugin by providers + decrease disable-warning priority #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcjkb
force-pushed
the
mj/3636-disable-warning-codeaction
branch
from
1508adf to
756601d
Compare
fendor
reviewed
Jun 10, 2023
mrcjkb
force-pushed
the
mj/3636-disable-warning-codeaction
branch
from
756601d to
4524262
Compare
Contributor
Author
|
The current test suite is fixed. I guess it would be nice to have a test that verifies that the "disable this warning" action appears last, but that would be outside the scope of the |
mrcjkb
force-pushed
the
mj/3636-disable-warning-codeaction
branch
from
4524262 to
7a6bc37
Compare
mrcjkb
force-pushed
the
mj/3636-disable-warning-codeaction
branch
from
7a6bc37 to
0381290
Compare
mrcjkb
force-pushed
the
mj/3636-disable-warning-codeaction
branch
from
0381290 to
746f7ea
Compare
fendor
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3636.