Add codeactions for cabal field names #3273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
cabal_field_codeactions
branch
from
84a291a to
b6282fb
Compare
fendor
force-pushed
the
cabal_field_codeactions
branch
2 times, most recently
from
e2201ec to
a3d902a
Compare
Collaborator
|
I rebased the PR and plan to push this over the finish line. Only tests are missing. |
fendor
force-pushed
the
cabal_field_codeactions
branch
from
a3d902a to
2327c14
Compare
Member
Kleidukos
previously requested changes
May 22, 2024
Member
Kleidukos
left a comment
Kleidukos
left a comment
There was a problem hiding this comment.
This is obviously a great addition, but it deserves a changelog entry. :)
Collaborator
|
@Kleidukos I was wondering, where do we have changelog entries in HLS? :D |
Member
|
I know the cabal plugin has a changelog |
Collaborator
|
you are indeed correct! |
fendor
force-pushed
the
cabal_field_codeactions
branch
2 times, most recently
from
f4422a3 to
817a74b
Compare
VeryMilkyJoe
approved these changes
May 28, 2024
fendor
force-pushed
the
cabal_field_codeactions
branch
from
817a74b to
228bad7
Compare
dyniec
force-pushed
the
cabal_field_codeactions
branch
from
228bad7 to
85fc20e
Compare
Contributor
Author
|
Rebased on top of current master branch. Changelogs are removed so no need to add entry |
fendor
approved these changes
Jun 8, 2024
auto-merge was automatically disabled
June 8, 2024 16:18
Head branch was pushed to by a user without write access
dyniec
force-pushed
the
cabal_field_codeactions
branch
from
85fc20e to
9ff4df1
Compare
Contributor
Author
|
fixed formatting |
fendor
force-pushed
the
cabal_field_codeactions
branch
from
9ff4df1 to
bf2e1fa
Compare
VeryMilkyJoe
force-pushed
the
cabal_field_codeactions
branch
from
bf2e1fa to
3055435
Compare
fendor
force-pushed
the
cabal_field_codeactions
branch
from
3055435 to
e6b6cd6
Compare
VeryMilkyJoe
force-pushed
the
cabal_field_codeactions
branch
from
e6b6cd6 to
200c8df
Compare
VeryMilkyJoe
force-pushed
the
cabal_field_codeactions
branch
from
200c8df to
26d3622
Compare
fendor
dismissed
Kleidukos’s stale review
We deleted changelogs and the review is about a missing changelog entries
Kleidukos
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3268 (and transitively on #2954).
Adds codeactions for misspelled field names in cabal files.
This change moves some inner workings of completions change, to use same logic (and same data).
examples: