Support ghc 9.4 for hls-class-plugin #3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
July541
requested review from
Ailrun,
Anton-Latukha and
michaelpj
as code owners
Ailrun
approved these changes
Oct 15, 2022
Member
Ailrun
left a comment
Ailrun
left a comment
There was a problem hiding this comment.
Does it work as-is? Sounds great :)
Collaborator
Author
|
The test looks fine, and I've tested it on my machine, nothing has a problem. I'm surprised too that it works without any code being modified :) |
July541
force-pushed
the
hls-class-plugin-9.4
branch
from
b80a823 to
29790a4
Compare
Ailrun
reviewed
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.