Stylish Haskell: CPP parse issues

[andys8]

Change

• CPP language extension
• Manually fix some files with duplication
• Fixed ignored filepaths in pre-commit config (ExactPrint was moved)

Result

Without this change

pre-commit run --show-diff-on-failure --all-files

plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction/ExactPrint.hs: <string>:7:1: error: parse error on input `#'
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction/Util.hs: <string>:14:1: error: parse error on input `#'
plugins/hls-refactor-plugin/src/Development/IDE/GHC/Compat/ExactPrint.hs: <string>:5:1: error: parse error on input `#'
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs: <string>:90:1: error: parse error on input `#'

With this change

System

stylish-haskell 0.14.2.0

Issue

• Related to pre-commit hook is failing locally and on CI #3170
• Followup of Solve formatting issues (stylish-haskell, pre-commit CI) #3171
• If there would be a way to tell stylish-haskell to skip parts of a file, these kind of issues could easier be solved without mangling with the code. It's doesn't exist. See feature: marker to ignore the following block stylish-haskell#409 (comment)

[andys8]

@pepeiborra Any chance pre-commit CI job can be required in order to prevent this to happen again in the future? It's way easier to fix (or wiggle around) a format issue right when you work on a file, rather than fail all - or now some - other PRs that have nothing to do with it.

[pepeiborra]

@pepeiborra Any change pre-commit CI job can be required in order to prevent this to happen again in the future? It's way easier to fix (or wiggle around) a format issue right when you work on a file, rather than fail all - or now some - other PRs that have nothing to do with it.

@andys8 thanks a lot for this fix, it is very appreciated. The pre-commit hook was contributed by @lunaticare and accepted by @Ailrun, maybe they can comment.

[pepeiborra]

My thoughts:

We have some of the worst CPP code in Haskell-land, it's bad enough for contributors as it is. Having to fight CI to make stylish-haskell "parse" the CPP will make things worse.

Ideally the pre-commit-hook would ignore parse errors, and leave those files untouched. Perhaps the exit code can be used to tell a parse error apart from an unformatted file?