Stan: Respect plugin configuration globalOn #3179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respects globalOn in stan plugin configuration and won't show hints anymore if the plugin is disabled.
pepeiborra
approved these changes
Sep 17, 2022
Collaborator
pepeiborra
left a comment
pepeiborra
left a comment
There was a problem hiding this comment.
This will do, thanks!
Collaborator
|
Indeed this looks good, @uhbif19 can tweak it afterwards if they like. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respects
globalOnin stan plugin configuration and won't show hints anymore if the plugin is disabled. Solves #3157Tested
Could verify the
globalOnsetting will be respected with a local project.About the change
Solves the issue (respecting if the plugin is disabled) the same way it is done in the hlint plugin, as hinted to by @pepeiborra in this comment thanks
@uhbif19 Since you wanted to take a look - hope it's okay and I ddin't take it away from you - is this fine? Any doubts? Also feel free to take over.