Skip to content

Disable flaky test on Windows #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Disable flaky test on Windows #3008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4204a8d
Disable flaky test on Windows
michaelpj Jul 1, 2022
8d99f3e
Merge branch 'master' into mpj/disable-flaky-hover-test
mergify[bot] Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ghcide/test/exe/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4439,7 +4439,11 @@ findDefinitionAndHoverTests = let
, test no yes holeL65 hleInfo2 "hole with variable"
, test no yes cccL17 docLink "Haddock html links"
, testM yes yes imported importedSig "Imported symbol"
, testM yes yes reexported reexportedSig "Imported symbol (reexported)"
, if | isWindows ->
-- Flaky on Windows: https://github.com/haskell/haskell-language-server/issues/2997
testM no yes reexported reexportedSig "Imported symbol (reexported)"
| otherwise ->
testM yes yes reexported reexportedSig "Imported symbol (reexported)"
, if | ghcVersion == GHC90 && isWindows ->
test no broken thLocL57 thLoc "TH Splice Hover"
| ghcVersion == GHC92 && (isWindows || isMac) ->
Expand Down