Drop support for pre-0.7 versions of the Fourmolu library #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these have genuine bugs, as discussed in #2254 (comment). We also get to drop a load of CPP introduced in #2944. Users can still use older versions via CLI mode. This wasn't possible until recently because `stylish-haskell`'s `ghc-lib-parser` bounds were holding us back.
Collaborator
|
Hmm, that's not going to happen soon probably. Per our deprecation policy, we're only going to drop support for 8.8 once Stackage LTS is on 9.2. |
Collaborator
Author
Indeed, hence the draft status. Seeing as I'd written the code before I realised we needed to be compatible so far back, I figured I may as well put it up. |
Collaborator
Author
|
This is pretty out-of-date after #3078. Which makes it slightly easier to maintain support for older versions anyway, be abstracting shims in to a separate module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't be merged while we still support GHC < 8.10, due to the dependency on
ghc-lib-parser-9.2.