Add scripts for releases and final 1.7 tweaks #2850
Conversation
The job fails for inscrutable reason, binaries will have to be manually compiled in a VM.
Also need to bump the minor versions of all packages which were not bumped since 1.6.1.1 and had changes to their testsuite.
wz1000
requested review from
Ailrun,
berberman,
drsooch,
eddiemundo,
fendor,
georgefst,
isovector,
jneira,
kokobd and
konn
as code owners
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you for the insane amount of time you are putting in!
wz1000
force-pushed
the
wip/1.7-release-scripts
branch
from
41bdac5 to
30435cb
Compare
wz1000
force-pushed
the
wip/1.7-release-scripts
branch
from
30435cb to
b1e084e
Compare
hasufell
left a comment
hasufell
left a comment
There was a problem hiding this comment.
I only skimmed over the python/bash scripts. Since they're not mandatory, I guess it's fine.
| case "${TARBALL_EXT}" in | ||
| zip) | ||
| HLS_VERSION="$("$CI_PROJECT_DIR/out/haskell-language-server-wrapper" --numeric-version)" | ||
| HLS_VERSION="$("$CI_PROJECT_DIR/out/haskell-language-server-8.10.7" --numeric-version)" |
There was a problem hiding this comment.
Why this change? This will break CI once 8.10.7 is deprecated, no?
There was a problem hiding this comment.
If hls-wrapper is compiled with 9.2.2 then the job fails because it can't find libgcc_s_seh-1.dll
There was a problem hiding this comment.
Yeah, this should have been fixed upstream weeks ago.
|
|
||
| hls: bindist/ghcs | ||
| for ghc in $(shell [ -e "bindist/ghcs-`uname`" ] && cat "bindist/ghcs-`uname`" || cat "bindist/ghcs") ; do \ | ||
| for ghc in $(shell [ -e "bindist/ghcs-`uname -o`" ] && cat "bindist/ghcs-`uname -o`" || cat "bindist/ghcs") ; do \ |
There was a problem hiding this comment.
-o is not a posix option afais: https://pubs.opengroup.org/onlinepubs/009695399/utilities/uname.html
There was a problem hiding this comment.
I tried it on Windows and FreeBSD, and it seems like the only way to detect mingw without a version number so I think it is OK.
| @@ -0,0 +1,154 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Note that /usr/bin/env is not guaranteed by posix either, contrary to popular belief of nix users.
The job fails for inscrutable reason, binaries will have to be manually compiled in a VM.
Also need to bump the minor versions of all packages which were not bumped since 1.6.1.1
and had changes to their testsuite.