Fix #2693 #2780
Merged
Fix #2693 #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Mar 14, 2022
Comment on lines
+780
to
+781
| evalGhcEnv hsc_env $ do | ||
| _ <- setSessionDynFlags $ df |
Collaborator
There was a problem hiding this comment.
uff, I hate these side effects. Hope this function is going to be removed soon :D
wz1000
force-pushed
the
wip/9.2-packages
branch
from
e649f5b to
ea6c792
Compare
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
We need to update the package database state in the `HscEnv` after we update its `DynFlags`. `setSessionDynFlags` handles this for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update the package database state in the
HscEnvafter we updateits
DynFlags.setSessionDynFlagshandles this for us.