Add space after comma when exporting a name #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is a fix for a whitespace inconsistency similar to described in #2399, thanks fo the contribution! |
jneira
approved these changes
Dec 28, 2021
Member
jneira
left a comment
jneira
left a comment
There was a problem hiding this comment.
lgtm, moreove looks better with a space imo
Collaborator
|
ghcide tests need updating |
Contributor
Author
|
Thanks for catching the tests bit, I've fixed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt that since
hls-explicit-imports-pluginputs spaces after commas then this code action should also do so for consistency.