Perform name lookup directly in TacticsM #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd managed to keep
IOout ofTacticsMthus far, but over time, it was beginning to creek. Rather than just looking up things likeMonoidif they were needed, I'd build a big static map of everything that might need to be looked up (KnownThings). And then, since user code in the metaprograms would need to look things up in the module, I stuck the parser inIO, plus a bunch of tomfoolery to make everything work.This PR just bites the bullet and puts some
IOintoTacticsM, allowing for runtime lookups. In doing so, it removesKnownThingsand a bunch of cruft around theParser. Everything is cleaner and there's a lot of red.