Skip to content

Add ability for plugins to handle file change notifications #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Add ability for plugins to handle file change notifications #1585

wants to merge 16 commits into from

Conversation

@alanz
Copy link
Collaborator

@alanz alanz commented Mar 17, 2021

This allows alternate parsers to be used, such as tree-sitter.

wz1000 and others added 16 commits February 10, 2021 22:24
@wz1000
WIP integrate haskell-lsp-1.0.0.0
93096df 
some progress

Mostly everything except LanguageServer.hs

make it compile

make it work

fix benchmarks

update

tweaks

fix configuration and tests

simplify handlers

Update to renamed lsp/lsp-types modules

redo plugin api and get library to compile

fill in some missing details

fix main

fix rebase
@wz1000
handle executeCommand and codeaction compat
61556c6
@wz1000
switch back to text
49fccf0
@wz1000
make ghcide tests compile
f075aab
@wz1000
non-formatting plugins
6712d07
@wz1000
simplify plugin api
cfce3f9
@wz1000
port default plugins
e9dcd29
@wz1000
fix hls tests
e4017d8
@wz1000
review comments
3f22f5c
@wz1000
more fixes
63a7270
@wz1000
more fixes
c3508bd
@wz1000
Fix more tests
8a2ed6d
@wz1000
cleanup
3beb7bc
@wz1000
fix cabal.project
37198dc
@wz1000
restore telemetry
159beb7
@alanz
Provide pluginNotificationhandlers too
3fd75b1 
Like pluginHandlers, but for notifications

At present the last one in the chain wins, so if one is set it
overrides the one built into ghcide
@alanz alanz requested a review from pepeiborra March 17, 2021 14:54
@jneira
Copy link
Member

jneira commented Mar 17, 2021

this needs a heavy rebase on máster, no? maybe we could set it as draft meanwhile?

@alanz alanz marked this pull request as draft March 17, 2021 15:31
@alanz
Copy link
Collaborator Author

alanz commented Mar 17, 2021

@jneira

this needs a heavy rebase on master, no?

Yes, I made it a draft as you suggested, it was more to show @pepeiborra what I have done, and it definitely needs a rebase.

@pepeiborra
Copy link
Collaborator

pepeiborra commented Mar 17, 2021

@alanz I'll rebase and send a new PR later this week

@pepeiborra pepeiborra closed this Mar 17, 2021
@pepeiborra pepeiborra mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj will be requested when the pull request is marked ready for review michaelpj is a code owner

@konn konn Awaiting requested review from konn konn will be requested when the pull request is marked ready for review konn is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 will be requested when the pull request is marked ready for review wz1000 is a code owner

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo will be requested when the pull request is marked ready for review eddiemundo is a code owner

@fendor fendor Awaiting requested review from fendor fendor will be requested when the pull request is marked ready for review fendor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alanz @jneira @pepeiborra @wz1000