Skip to content

Change Wingman module structure, address -Wall #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 8, 2021
Merged

Change Wingman module structure, address -Wall #1519

merged 8 commits into from
Mar 8, 2021

Conversation

@isovector
Copy link
Collaborator

@isovector isovector commented Mar 7, 2021

This PR:

  • Changes the Ide.Plugin.Tactic. module prefix to Wingman.
  • Moves Ide.Plugin.Tactic to Wingman.Plugin, but re-exports it as Ide.Plugin.Tactic
  • Updates the default extensions to a reasonable set, removes them as per-file options
  • Enables -Wall and fixes the few warnings that came up

@isovector isovector added the merge me Label to trigger pull request merge label Mar 8, 2021
@mergify mergify bot merged commit 00c954d into haskell:master Mar 8, 2021
@isovector isovector deleted the wingman-module-structure branch April 5, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isovector @pepeiborra