Patch pre-commit-hook to work with GHCIDE/hls-plugin-api codes #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit does not load stylish-haskell configuration in subdirectories. As an imperfect workaround, this commit unifies all stylish-haskell into a single top-level config.
Ailrun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1416
As a temporary workaround, this PR unifies all
.stylish-haskell.yamlinto a single top-level config.excludesfield for pre-commit-hook.nix is a regex, not a grep. Moreover, file paths that pre-commit passes do not start with an initial/even when a file is at the root directory of the project.This PR fixes the value for the field.