Skip to content

Conversation

@berberman
Copy link
Collaborator

@berberman berberman commented Feb 12, 2021

Closes #682

According to GHC Wiki:

`data T = MkT { x :: Int }`

When DuplicateRecordFields is enabled, field accessors become "selectors". For example, the corresponding GlobalRdrElt of above x is x |-> GRE $sel:x:MkT (FldParent T (Just x)) LocalDef. So we can't use gre_name($sel:x:MkT) for completion, but par_lbl(x) of its parent.

In this PR, item names are converted into OccNames before passed to mkNameCompItem, resulting in no renamed filed selector occuring in the result.

  • regression test

@berberman berberman marked this pull request as ready for review February 13, 2021 10:29
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepeiborra pepeiborra merged commit e2bf01b into haskell:master Feb 13, 2021
@berberman berberman deleted the fix-completion branch February 14, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect completion text when using DuplicateRecordFields

2 participants