Skip to content

Conversation

@jneira
Copy link
Member

@jneira jneira commented Jan 11, 2021

The mergify config is not completely updated and is required to remove them to unblock
#1173

The mergify config is not completely updated and is required
to remove them to unblock
haskell#1173
@jneira jneira requested review from Ailrun and pepeiborra January 11, 2021 06:41
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problematic part is the GitHub repository setting, not mergify setting... but this change (followed by #1173) looks good to me.

@jneira
Copy link
Member Author

jneira commented Jan 11, 2021

I think the problematic part is the GitHub repository setting

what specific setting are you thinking about? make all checks required to merge a pr?

@jneira jneira added the merge me Label to trigger pull request merge label Jan 11, 2021
@Ailrun
Copy link
Member

Ailrun commented Jan 11, 2021

The setting I'm thinking about is the branch protection rules, which may refer some outdated checks.

@jneira
Copy link
Member Author

jneira commented Jan 11, 2021

Mmm you are right, there are a list of checks and we have to update them when #1173 lands, included removing the obsolete ones removed here for mergify.
In fact there are existing checks not required in those settings: test (8.10.3, ubuntu-latest) f.e.

@jneira jneira merged commit 16aee6e into haskell:master Jan 11, 2021
@jneira jneira deleted the remove-old-checks branch January 11, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants