-
-
Notifications
You must be signed in to change notification settings - Fork 412
Use cabal-helper-1.1, add stack-8.10.1.yaml and unify cabal.project's #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cabal.project
Outdated
| tag: 78f888f46dae96922d855af1e6a00ea6bb856987 | ||
|
|
||
| -- TODO adapt code to last opentelemetry-0.4.0 | ||
| constraints: opentelemetry == 0.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed in mpickering/ghcide on the hls branch. Maybe we can update ghcide first?
alanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this,when you resolve the timing issues for the upstream repo
|
|
Failing ci builds are in the test step so it seems the build itself works. |
cabal-helper-1.1in windows had been necessary pump up Cabal version to3.0.2.0in stack.yaml'scabal.projectthat works forghc-8.10.1and a newstack-8.10.1.yamlboth withoutallow-newerghc-8.10.1in floskell and cabal-planbrittanyneeds more work to be upgraded, cabal is already excluding it auto from the build plan setting-agplagplto False temporary in stack (with a comment about)opentelemeryto0.3incabal.projectcause the more recent version0.4is not compatible with our code